Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back class that sets overflow on phenogrid container #891

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ptgolden
Copy link
Member

It was removed in 2c878e8 and broke the display of certain embedded phenogrid widgets (see #887)

Related issues

It was removed in 2c878e8 and broke the display of certain embedded
phenogrid widgets (see #887)
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit d67b21e
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/6734e8054c7e7f00087117b8
😎 Deploy Preview https://deploy-preview-891--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.30%. Comparing base (64b4d01) to head (d67b21e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          91       91           
  Lines        3136     3136           
=======================================
  Hits         2236     2236           
  Misses        900      900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpavam
Copy link

dpavam commented Nov 14, 2024

Thank you @ptgolden. I tested this branch on the IMPC website, and the phenogrid is displaying as expected.

@kevinschaper kevinschaper merged commit ac017e1 into main Nov 15, 2024
11 checks passed
@kevinschaper kevinschaper deleted the issue-887-phenogrid-overflow branch November 15, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants